lkml.org 
[lkml]   [2023]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 1/5] mfd: Add support for Intel LJCA device
    Hi Greg,

    Thanks for the review.
    On Thu, Mar 09, 2023 at 08:49:33AM +0100, Greg Kroah-Hartman wrote:
    > On Thu, Mar 09, 2023 at 03:10:56PM +0800, Ye Xiang wrote:
    > > This patch implements the USB part of Intel USB-I2C/GPIO/SPI adapter
    > > device named "La Jolla Cove Adapter" (LJCA).
    >
    > Then why is this called "mfd" in the subject line?
    Sorry, it's a mistake. I forget to change mfd to usb in the commit message
    because I just move the ljca.c from driver/mfd to drivers/usb/misc according
    to previous review comments[1]. And I will address this on v5.

    [1] https://www.spinics.net/lists/kernel/msg4708451.html
    >
    > > include/linux/mfd/ljca.h | 95 ++++
    >
    > Why is this .h file in the mfd directory?
    It's a mistake as well. Will address it by moving include/linux/mfd/ljca.h
    to include/linux/usb/ljca.h.
    >
    > thanks,
    >
    > greg k-h

    --
    Thanks
    Ye Xiang

    \
     
     \ /
      Last update: 2023-03-27 00:51    [W:6.818 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site