Messages in this thread | | | Subject | Re: [PATCH] clk: Avoid invalid function names in CLK_OF_DECLARE() | From | Stephen Boyd <> | Date | Thu, 09 Mar 2023 15:39:04 -0800 |
| |
Quoting Nathan Chancellor (2023-03-08 12:47:11) > After commit c28cd1f3433c ("clk: Mark a fwnode as initialized when using > CLK_OF_DECLARE() macro"), drivers/clk/mvebu/kirkwood.c fails to build: > > drivers/clk/mvebu/kirkwood.c:358:1: error: expected identifier or '(' > CLK_OF_DECLARE(98dx1135_clk, "marvell,mv98dx1135-core-clock", > ^ > include/linux/clk-provider.h:1367:21: note: expanded from macro 'CLK_OF_DECLARE' > static void __init name##_of_clk_init_declare(struct device_node *np) \ > ^ > <scratch space>:124:1: note: expanded from here > 98dx1135_clk_of_clk_init_declare > ^ > drivers/clk/mvebu/kirkwood.c:358:1: error: invalid digit 'd' in decimal constant > include/linux/clk-provider.h:1372:34: note: expanded from macro 'CLK_OF_DECLARE' > OF_DECLARE_1(clk, name, compat, name##_of_clk_init_declare) > ^ > <scratch space>:125:3: note: expanded from here > 98dx1135_clk_of_clk_init_declare > ^ > drivers/clk/mvebu/kirkwood.c:358:1: error: invalid digit 'd' in decimal constant > include/linux/clk-provider.h:1372:34: note: expanded from macro 'CLK_OF_DECLARE' > OF_DECLARE_1(clk, name, compat, name##_of_clk_init_declare) > ^ > <scratch space>:125:3: note: expanded from here > 98dx1135_clk_of_clk_init_declare > ^ > drivers/clk/mvebu/kirkwood.c:358:1: error: invalid digit 'd' in decimal constant > include/linux/clk-provider.h:1372:34: note: expanded from macro 'CLK_OF_DECLARE' > OF_DECLARE_1(clk, name, compat, name##_of_clk_init_declare) > ^ > <scratch space>:125:3: note: expanded from here > 98dx1135_clk_of_clk_init_declare > ^ > > C function names must start with either an alphabetic letter or an > underscore. To avoid generating invalid function names from clock names, > add two underscores to the beginning of the identifier. > > Fixes: c28cd1f3433c ("clk: Mark a fwnode as initialized when using CLK_OF_DECLARE() macro") > Suggested-by: Saravana Kannan <saravanak@google.com> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > ---
Applied to clk-fixes
| |