Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 9 Mar 2023 14:56:24 -0800 | Subject | Re: [RFC PATCH v2 1/3] ufs: mcq: Add supporting functions for mcq abort | From | "Bao D. Nguyen" <> |
| |
On 3/9/2023 2:54 PM, Bart Van Assche wrote: > On 3/9/23 14:47, Bao D. Nguyen wrote: >> On 3/9/2023 10:15 AM, Bart Van Assche wrote: >>> On 3/8/23 21:28, Bao D. Nguyen wrote: >>>> +static inline bool ufshcd_mcq_is_sq_empty(struct ufs_hw_queue *q) >>>> +{ >>>> + return q->sq_head_slot == q->sq_tail_slot; >>>> +} >>> >>> Please remove this function and inline this function into its callers. >> >> Same comment. Should I also update the existing >> ufshcd_mcq_is_cq_empty() in a separate patch together with >> ufshcd_mcq_update_cq_tail_slot(), ufshcd_mcq_update_cq_head() >> mentioned above? > > Hi Bao, > > Modifying the existing code may improve uniformity of the UFS host > controller driver. If any existing code is refactored, please do that > via a separate patch. Thanks Bart. I will make that change in a separate patch. > > Thanks, > > Bart. >
| ![\](/images/icornerr.gif) |