lkml.org 
[lkml]   [2023]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523
From

[...]
= of_graph_get_remote_node(dsi->dev.of_node, 1, -1);
>>>>> + if (!dsi1) {
>>>>> + dev_err(dev, "cannot get secondary DSI node.\n");
>>>>> + return -ENODEV;
>>>>> + }
>>>>> +
>>>>> + dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
>>>>> + of_node_put(dsi1);
>>>> Shouldn't you put the reference only if it's found?
>>> thanks for spot it.
Apparently not.. please don't change this

Konrad
>>>>
>>>>> + if (!dsi1_host) {
>>>>> + dev_err(dev, "cannot get secondary DSI host\n");
>>>>> + return -EPROBE_DEFER;
>>>> dev_err_probe, here and in neighbouring exit return paths?
>>> Acked.
>>>>
>>>>
>>>> Konrad

\
 
 \ /
  Last update: 2023-03-27 00:52    [W:0.172 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site