Messages in this thread | | | Date | Thu, 9 Mar 2023 15:36:58 +0800 | Subject | Re: erofs: use wrapper i_blocksize() in erofs_file_read_iter() | From | Jingbo Xu <> |
| |
On 3/9/23 3:15 PM, Yangtao Li wrote: >> @@ -380,7 +380,7 @@ static ssize_t erofs_file_read_iter(struct kiocb *iocb, struct iov_iter *to) >> if (bdev) >> blksize_mask = bdev_logical_block_size(bdev) - 1; >> else >> - blksize_mask = (1 << inode->i_blkbits) - 1; >> + blksize_mask = i_blocksize(inode) - 1; > > Since the mask is to be obtained here, is it more appropriate to use GENMASK(inode->i_blkbits - 1, 0)?
FYI it seems that GENMASK macro is widely used in driver and arch code base, while it's rarely used in fs, except for f2fs.
-- Thanks, Jingbo
| |