lkml.org 
[lkml]   [2023]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1] scsi: ufs: core: print trs for pending requests in MCQ mode
From
On 3/8/23 21:01, Ziqi Chen wrote:
> +static void ufshcd_print_trs_all(struct ufs_hba *hba, bool pr_prdt)
> +{
> + const struct ufshcd_lrb *lrbp;
> + int tag;
> +
> + for (tag = 0; tag < hba->nutrs; tag++) {
> + lrbp = &hba->lrb[tag];
> +
> + if (lrbp->cmd)
> + ufshcd_print_tr(hba, tag, pr_prdt);
> }
> }

There is a race in this code: lrbp->cmd may be cleared after it has been
read and before or while ufshcd_print_tr() is in progress. How about
preventing that race by blk_mq_tagset_busy_iter() to iterate over
pending SCSI commands?

Thanks,

Bart.

\
 
 \ /
  Last update: 2023-03-27 00:52    [W:0.042 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site