Messages in this thread | | | Date | Thu, 9 Mar 2023 19:10:25 +0300 | From | Fedor Pchelkin <> | Subject | Re: [PATCH] nfc: pn533: initialize struct pn533_out_arg properly |
| |
On Tue, Mar 07, 2023 at 04:45:30PM +0100, Simon Horman wrote: > > nit: This doesn't follow reverse xmas tree ordering - longest to shortest line. > It's probably not worth respinning, but I expect the preferred > approach is (*completely untested!*) > > ... > struct pn533_out_arg arg; > ... > > arg.phy = phy; >
That is much prettier, thanks for advice!
BTW, is reverse xmas tree ordering considered to be a general recommendation for all new kernel patches?
| |