Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting() | From | Edward Cree <> | Date | Wed, 8 Mar 2023 16:16:45 +0000 |
| |
On 07/03/2023 18:19, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > 51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to > pci_disable_pcie_error_reporting() in ef100_pci_remove(). > > Remove this call since there's no apparent reason to disable error > reporting when it was not previously enabled. > > Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core enables PCIe error reporting for all devices during > enumeration, so the driver doesn't need to do it itself. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Cc: Edward Cree <ecree.xilinx@gmail.com> > Cc: Martin Habets <habetsm.xilinx@gmail.com> > ---
Yeah it looks like we meant to add an enable too but lost it somewhere in the upstreaming process. Anyway, Acked-by: Edward Cree <ecree.xilinx@gmail.com>
| ![\](/images/icornerr.gif) |