Messages in this thread | | | Date | Wed, 8 Mar 2023 17:50:11 +0200 | From | Heikki Krogerus <> | Subject | Re: [PATCH v3 06/20] usb: ulpi: Use of_request_module() |
| |
On Wed, Mar 08, 2023 at 04:31:46PM +0100, Miquel Raynal wrote: > There is a new helper supposed to replace of_device_request_module(), > called of_request_module(). They are both strictly equivalent, besides > the fact the latter receives a "struct device_node" directly. Use it. > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> --- > drivers/usb/common/ulpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c > index a98b2108376a..6977cf380838 100644 > --- a/drivers/usb/common/ulpi.c > +++ b/drivers/usb/common/ulpi.c > @@ -229,7 +229,7 @@ static int ulpi_read_id(struct ulpi *ulpi) > request_module("ulpi:v%04xp%04x", ulpi->id.vendor, ulpi->id.product); > return 0; > err: > - of_device_request_module(&ulpi->dev); > + of_request_module(ulpi->dev.of_node); > return 0; > } > > -- > 2.34.1
-- heikki
| |