Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 8 Mar 2023 11:25:34 +0100 | Subject | Re: [PATCH v1 2/2] hwmon: ina2xx: add optional regulator support | From | Krzysztof Kozlowski <> |
| |
On 08/03/2023 10:40, Svyatoslav Ryhel wrote: > Some devices may need a specific supply provided > for this sensor to work properly, like p895 does. > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > --- > drivers/hwmon/ina2xx.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c > index 00fc70305a89..4a3e2b1bbe8b 100644 > --- a/drivers/hwmon/ina2xx.c > +++ b/drivers/hwmon/ina2xx.c > @@ -119,6 +119,7 @@ struct ina2xx_data { > long power_lsb_uW; > struct mutex config_lock; > struct regmap *regmap; > + struct regulator *vdd_supply; > > const struct attribute_group *groups[INA2XX_MAX_ATTRIBUTE_GROUPS]; > }; > @@ -656,6 +657,17 @@ static int ina2xx_probe(struct i2c_client *client) > return PTR_ERR(data->regmap); > } > > + data->vdd_supply = devm_regulator_get_optional(dev, "vdd"); > + if (IS_ERR(data->vdd_supply)) > + return dev_err_probe(dev, PTR_ERR(data->vdd_supply), > + "failed to get vdd regulator\n"); > + > + ret = regulator_enable(data->vdd_supply); > + if (ret < 0) { > + dev_err(dev, "failed to enable vdd power supply\n"); > + return ret;
And where is disable? On each error path, removal etc.
Best regards, Krzysztof
| ![\](/images/icornerr.gif) |