Messages in this thread | ![/](/images/icornerl.gif) | | From | Po-Hsu Lin <> | Date | Wed, 8 Mar 2023 18:21:57 +0800 | Subject | Re: [PATCHv2] selftests: net: devlink_port_split.py: skip test if no suitable device available |
| |
On Wed, Mar 8, 2023 at 5:31 PM Jiri Pirko <jiri@resnulli.us> wrote: > > Tue, Mar 07, 2023 at 04:00:30PM CET, po-hsu.lin@canonical.com wrote: > >The `devlink -j port show` command output may not contain the "flavour" > >key, an example from s390x LPAR with Ubuntu 22.10 (5.19.0-37-generic), > >iproute2-5.15.0: > > {"port":{"pci/0001:00:00.0/1":{"type":"eth","netdev":"ens301"}, > > "pci/0001:00:00.0/2":{"type":"eth","netdev":"ens301d1"}, > > "pci/0002:00:00.0/1":{"type":"eth","netdev":"ens317"}, > > "pci/0002:00:00.0/2":{"type":"eth","netdev":"ens317d1"}}} > > As Jakub wrote, this is odd. Could you debug if kernel sends the flavour > attr and if not why? Also, could you try with most recent kernel?
I did a quick check on another s390x LPAR instance which is running with Ubuntu 23.04 (6.1.0-16-generic) iproute2-6.1.0, there is still no "flavour" attribute. $ devlink port show pci/0001:00:00.0/1: type eth netdev ens301 pci/0001:00:00.0/2: type eth netdev ens301d1 pci/0002:00:00.0/1: type eth netdev ens317 pci/0002:00:00.0/2: type eth netdev ens317d1
The behaviour didn't change with iproute2 built from source [1]
[1] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/
| ![\](/images/icornerr.gif) |