Messages in this thread | | | Subject | Re: [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock index | From | zhuyinbo <> | Date | Wed, 8 Mar 2023 17:24:26 +0800 |
| |
在 2023/3/8 下午4:37, Krzysztof Kozlowski 写道: > On 08/03/2023 02:35, zhuyinbo wrote: >> 在 2023/3/7 下午8:47, Krzysztof Kozlowski 写道: >>> On 07/03/2023 12:50, Yinbo Zhu wrote: >>>> The Loongson-2 boot clock was used to spi and lio peripheral and >>>> this patch was to add boot clock index number. >>>> >>>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> >>>> --- >>> This is v13? Where is the changelog then? >> in fact, this is a new patch(v1), but another clock driver patch in >> this series had send as v13 and need depend on >> >> this patch so set current patch as v13. > This should be explained in changelog.
okay I got it , and I whether need resend a v14 patch that in order to add this explain in changelog ?
> >>> >>>> include/dt-bindings/clock/loongson,ls2k-clk.h | 25 ++++++++++--------- >>>> 1 file changed, 13 insertions(+), 12 deletions(-) >>>> >>>> diff --git a/include/dt-bindings/clock/loongson,ls2k-clk.h b/include/dt-bindings/clock/loongson,ls2k-clk.h >>>> index db1e27e792ff1..e86804365e506 100644 >>>> --- a/include/dt-bindings/clock/loongson,ls2k-clk.h >>>> +++ b/include/dt-bindings/clock/loongson,ls2k-clk.h >>>> @@ -13,17 +13,18 @@ >>>> #define LOONGSON2_DC_PLL 3 >>>> #define LOONGSON2_PIX0_PLL 4 >>>> #define LOONGSON2_PIX1_PLL 5 >>>> -#define LOONGSON2_NODE_CLK 6 >>>> -#define LOONGSON2_HDA_CLK 7 >>>> -#define LOONGSON2_GPU_CLK 8 >>>> -#define LOONGSON2_DDR_CLK 9 >>>> -#define LOONGSON2_GMAC_CLK 10 >>>> -#define LOONGSON2_DC_CLK 11 >>>> -#define LOONGSON2_APB_CLK 12 >>>> -#define LOONGSON2_USB_CLK 13 >>>> -#define LOONGSON2_SATA_CLK 14 >>>> -#define LOONGSON2_PIX0_CLK 15 >>>> -#define LOONGSON2_PIX1_CLK 16 >>>> -#define LOONGSON2_CLK_END 17 >>>> +#define LOONGSON2_BOOT_CLK 6 >>> That's an ABI break and commit msg does not explain it. >> you meaning is that need add a explanation in commit msg that why > You need good explanation to break the ABI. I don't understand the > commit msg, but anyway I could not find there justification for ABI > break. If you do not have good justification, don't break the ABI,
The commit msg is the patch commit log, and I maybe not got it about break the ABI. You said about "break the ABI"
is whether is location issue about "LOONGSON2_BOOT_CLK"? if yes, the LOONGSON2_BOOT_CLK was placed
after LOONGSON2_PIX1_PLL that is due to their clock parent is same. and I whether need add this explanation
in patch commit log description?
> > > > Best regards, > Krzysztof
| |