Messages in this thread | | | From | Svyatoslav Ryhel <> | Date | Wed, 8 Mar 2023 10:58:26 +0200 | Subject | Re: [PATCH v1] max77663-rtc: pass rtc address from device tree node if exists |
| |
I would love to, but max77663 uses max77686 rtc https://github.com/torvalds/linux/blob/master/drivers/mfd/max77620.c#L123 how to handle this?
ср, 8 бер. 2023 р. о 10:54 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> пише: > > On 08/03/2023 09:37, Svyatoslav Ryhel wrote: > > MAX77663 PMIC can have RTC on both 0x63 i2c address (like grouper) > > which is main address but on some devices RTC is located on 0x48 > > i2c address (like p880 and p895 from LG). Lets add property to be > > able to use alternative address if needed without breaking existing > > bindings. > > Use subject prefixes matching the subsystem (which you can get for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching). > > Anyway this is not max77663 driver. > > The property does not make sense in the context of max77686. Maybe for > max77802/77620 and 77714 would have... but still max77663 is not there. > Don't add properties for unrelated and unsupported devices. > > Best regards, > Krzysztof >
| |