Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Thu, 9 Mar 2023 12:40:33 +0800 | Subject | Re: [PATCH 1/4] dt-bindings: thermal: mediatek: Add AP domain to LVTS thermal controllers for mt8195 |
| |
On Wed, Mar 8, 2023 at 12:46 AM <bchihi@baylibre.com> wrote: > > From: Balsam CHIHI <bchihi@baylibre.com> > > Add AP Domain to LVTS thermal controllers dt-binding definition for mt8195. > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > --- > include/dt-bindings/thermal/mediatek,lvts-thermal.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/dt-bindings/thermal/mediatek,lvts-thermal.h b/include/dt-bindings/thermal/mediatek,lvts-thermal.h > index c09398920468..8fa5a46675c4 100644 > --- a/include/dt-bindings/thermal/mediatek,lvts-thermal.h > +++ b/include/dt-bindings/thermal/mediatek,lvts-thermal.h > @@ -16,4 +16,14 @@ > #define MT8195_MCU_LITTLE_CPU2 6 > #define MT8195_MCU_LITTLE_CPU3 7 > > +#define MT8195_AP_VPU0 8
Can't this start from 0? This is a different hardware block. The index namespace is separate. Same question for MT8192.
ChenYu
> +#define MT8195_AP_VPU1 9 > +#define MT8195_AP_GPU0 10 > +#define MT8195_AP_GPU1 11 > +#define MT8195_AP_VDEC 12 > +#define MT8195_AP_IMG 13 > +#define MT8195_AP_INFRA 14 > +#define MT8195_AP_CAM0 15 > +#define MT8195_AP_CAM1 16 > + > #endif /* __MEDIATEK_LVTS_DT_H */ > -- > 2.34.1 > >
| |