lkml.org 
[lkml]   [2023]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/19] PCI: qcom-ep: Rename "mmio" region to "mhi"
On Tue, Mar 07, 2023 at 09:19:29AM +0100, Krzysztof Kozlowski wrote:
> On 06/03/2023 16:32, Manivannan Sadhasivam wrote:
> > As per Qualcomm's internal documentation, the name of the region is "mhi"
> > and not "mmio". So let's rename it to follow the convention.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
>
>
>
> >
> > @@ -477,16 +477,16 @@ static int qcom_pcie_ep_get_io_resources(struct platform_device *pdev,
> > if (IS_ERR(pcie_ep->elbi))
> > return PTR_ERR(pcie_ep->elbi);
> >
> > - pcie_ep->mmio_res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> > - "mmio");
> > - if (!pcie_ep->mmio_res) {
> > - dev_err(dev, "Failed to get mmio resource\n");
> > + pcie_ep->mhi_res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> > + "mhi");
>
> That's an ABI break. Patchset is also non-bisectable.
>

As agreed, I will drop this patch in next revision.

Thanks,
Mani

> Best regards,
> Krzysztof
>

--
மணிவண்ணன் சதாசிவம்

\
 
 \ /
  Last update: 2023-03-27 00:49    [W:1.013 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site