Messages in this thread | | | Date | Thu, 9 Mar 2023 09:48:30 +0800 | From | Zhenyu Wang <> | Subject | Re: [PATCH] perf/x86/intel: use hexidecimal value for cpuid |
| |
On 2023.03.08 15:16:19 +0100, Peter Zijlstra wrote: > On Wed, Mar 08, 2023 at 11:15:01AM +0800, Zhenyu Wang wrote: > > It's easier to use hexidecimal value instead of decimal for reading > > and following with SDM doc, also align with other cpuid calls. > > *shrug*.. > > > Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> > > --- > > arch/x86/events/intel/core.c | 2 +- > > arch/x86/events/intel/lbr.c | 2 +- > > arch/x86/events/intel/pt.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c > > index 14f0a746257d..5af084198c8f 100644 > > --- a/arch/x86/events/intel/core.c > > +++ b/arch/x86/events/intel/core.c > > @@ -5903,7 +5903,7 @@ __init int intel_pmu_init(void) > > * Check whether the Architectural PerfMon supports > > * Branch Misses Retired hw_event or not. > > */ > > - cpuid(10, &eax.full, &ebx.full, &fixed_mask, &edx.full); > > + cpuid(0xA, &eax.full, &ebx.full, &fixed_mask, &edx.full); > > if (eax.split.mask_length < ARCH_PERFMON_EVENTS_COUNT) > > return -ENODEV; > > But now the data type names and the cpuid calls are no longer related.
oh, right, missed that. How about we change those too e.g union cpuid_0xa_eax? [unhandled content-type:application/pgp-signature] | |