lkml.org 
[lkml]   [2023]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH v1 2/4] ufs: mcq: Add supporting functions for mcq abort
From
Hi Bart, thank you very much for the reviews.

On 3/8/2023 10:48 AM, Bart Van Assche wrote:
> On 3/7/23 20:01, Bao D. Nguyen wrote:
>> +/* Maximum MCQ registers polling time */
>
> registers -> register
I will make the change in the next rev.
>
>> +#define MCQ_POLL_TIMEOUT   500
>
>>       struct ufshcd_mcq_opr_info_t mcq_opr[OPR_MAX];
>> +    u32 mcq_poll_ms;
>>   };
>
> Why has the new member variable 'mcq_poll_ms' been introduced since
> its value is never changed?
>
This is to give us the flexibility to override this parameter in the
downstream driver if needed.
> Thanks,
>
> Bart.


\
 
 \ /
  Last update: 2023-03-27 00:50    [W:0.054 / U:0.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site