lkml.org 
[lkml]   [2023]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 19/20] dt-bindings: pinctrl: mediatek: mt7620: split binding
    On Fri, Mar 03, 2023 at 03:28:48AM +0300, arinc9.unal@gmail.com wrote:
    > From: Arınç ÜNAL <arinc.unal@arinc9.com>
    >
    > The MT7628 and MT7688 SoCs contain different pin muxing information,
    > therefore, should be split. This can be done now that there are compatible
    > strings to distinguish them from other SoCs.
    >
    > Split the schema out to mediatek,mt76x8-pinctrl.yaml.
    >
    > Remove mediatek,mt76x8-pinctrl from mt7620.
    >
    > Deprecate ralink,mt7620-pinctrl. The reason is, the DTs for mt76x8 which
    > use this string will incorrectly match the pin muxing information for
    > mt7620. There's a new string, mediatek,mt7620-pinctrl, which makes the
    > deprecation possible.

    This should be 2 patches.

    You aren't deprecating either. That means still documented and labeled
    with 'deprecated: true'. But again, just 'fixing' the vendor is not a
    reason to deprecate and for us to have to carry the old compatible. We
    deprecate when there is some advantage to it such as using common
    properties instead of vendor specific ones.

    Rob

    \
     
     \ /
      Last update: 2023-03-27 00:50    [W:6.271 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site