lkml.org 
[lkml]   [2023]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v17 09/14] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing
    On Wed, Mar 08, 2023 at 04:52:46PM +0000, David Howells wrote:
    > ZERO_PAGE can't go away, no need to hold an extra reference.
    >
    > Signed-off-by: David Howells <dhowells@redhat.com>
    > Reviewed-by: David Hildenbrand <david@redhat.com>
    > Reviewed-by: John Hubbard <jhubbard@nvidia.com>
    > cc: Al Viro <viro@zeniv.linux.org.uk>
    > cc: David Hildenbrand <david@redhat.com>
    > cc: linux-fsdevel@vger.kernel.org
    > ---
    > fs/iomap/direct-io.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
    > index f771001574d0..850fb9870c2f 100644
    > --- a/fs/iomap/direct-io.c
    > +++ b/fs/iomap/direct-io.c
    > @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio,
    > bio->bi_private = dio;
    > bio->bi_end_io = iomap_dio_bio_end_io;
    >
    > - get_page(page);
    > + bio_set_flag(bio, BIO_NO_PAGE_REF);
    > __bio_add_page(bio, page, len, 0);
    > iomap_dio_submit_bio(iter, dio, bio, pos);
    > }

    Looks fine.

    Reviewed-by: Dave Chinner <dchinner@redhat.com>
    --
    Dave Chinner
    david@fromorbit.com

    \
     
     \ /
      Last update: 2023-03-27 00:50    [W:2.774 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site