lkml.org 
[lkml]   [2023]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] IB/qib: Drop redundant pci_enable_pcie_error_reporting()
    From
    On 3/7/23 2:32 PM, Bjorn Helgaas wrote:
    > From: Bjorn Helgaas <bhelgaas@google.com>
    >
    > pci_enable_pcie_error_reporting() enables the device to send ERR_*
    > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
    > native"), the PCI core does this for all devices during enumeration, so the
    > driver doesn't need to do it itself.
    >
    > Remove the redundant pci_enable_pcie_error_reporting() call from the
    > driver.
    >
    > Note that this only controls ERR_* Messages from the device. An ERR_*
    > Message may cause the Root Port to generate an interrupt, depending on the
    > AER Root Error Command register managed by the AER service driver.
    >
    > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    > Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>

    Reviewed-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>

    \
     
     \ /
      Last update: 2023-03-27 00:50    [W:8.071 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site