lkml.org 
[lkml]   [2023]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 1/2] dt-bindings: power: Add binding for MediaTek MT6735 power controller
    From
    On 02/03/2023 13:27, Yassine Oudjana wrote:
    > From: Yassine Oudjana <y.oudjana@protonmail.com>
    >
    > Add DT binding for MediaTek MT6735 SCPSYS power controller.
    >
    > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
    > ---
    > .../bindings/power/mediatek,power-controller.yaml | 2 ++
    > .../devicetree/bindings/soc/mediatek/scpsys.txt | 1 +
    > include/dt-bindings/power/mt6735-power.h | 14 ++++++++++++++
    > 3 files changed, 17 insertions(+)
    > create mode 100644 include/dt-bindings/power/mt6735-power.h
    >
    > diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
    > index c9acef80f452..710db61cab53 100644
    > --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
    > +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
    > @@ -23,6 +23,7 @@ properties:
    >
    > compatible:
    > enum:
    > + - mediatek,mt6735-power-controller
    > - mediatek,mt6795-power-controller
    > - mediatek,mt8167-power-controller
    > - mediatek,mt8173-power-controller
    > @@ -81,6 +82,7 @@ $defs:
    > reg:
    > description: |
    > Power domain index. Valid values are defined in:
    > + "include/dt-bindings/power/mt6735-power.h" - for MT6735 type power domain.

    Isn't the comment obvious? Maybe let's stop adding them?

    > "include/dt-bindings/power/mt6795-power.h" - for MT8167 type power domain.
    > "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain.
    > "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain.
    > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
    > index 2bc367793aec..3530a6668b48 100644
    > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
    > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
    > @@ -20,6 +20,7 @@ Required properties:
    > - compatible: Should be one of:
    > - "mediatek,mt2701-scpsys"
    > - "mediatek,mt2712-scpsys"
    > + - "mediatek,mt6735-scpsys"
    > - "mediatek,mt6765-scpsys"
    > - "mediatek,mt6797-scpsys"
    > - "mediatek,mt7622-scpsys"
    > diff --git a/include/dt-bindings/power/mt6735-power.h b/include/dt-bindings/power/mt6735-power.h
    > new file mode 100644
    > index 000000000000..782b49a88773
    > --- /dev/null
    > +++ b/include/dt-bindings/power/mt6735-power.h

    I am pretty sure we already discussed the file naming with some other
    patches... mediatek,mt6735-power-controller.h

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-03-27 00:50    [W:9.556 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site