lkml.org 
[lkml]   [2023]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net] net: microchip: sparx5: fix deletion of existing DSCP mappings
    On Tue, Mar 07, 2023 at 12:21:03PM +0100, Daniel Machon wrote:
    > Fix deletion of existing DSCP mappings in the APP table.
    >
    > Adding and deleting DSCP entries are replicated per-port, since the
    > mapping table is global for all ports in the chip. Whenever a mapping
    > for a DSCP value already exists, the old mapping is deleted first.
    > However, it is only deleted for the specified port. Fix this by calling
    > sparx5_dcb_ieee_delapp() instead of dcb_ieee_delapp() as it ought to be.
    >
    > Reproduce:
    >
    > // Map and remap DSCP value 63
    > $ dcb app add dev eth0 dscp-prio 63:1
    > $ dcb app add dev eth0 dscp-prio 63:2
    >
    > $ dcb app show dev eth0 dscp-prio
    > dscp-prio 63:2
    >
    > $ dcb app show dev eth1 dscp-prio
    > dscp-prio 63:1 63:2 <-- 63:1 should not be there
    >
    > Fixes: 8dcf69a64118 ("net: microchip: sparx5: add support for offloading dscp table")
    > Signed-off-by: Daniel Machon <daniel.machon@microchip.com>

    Reviewed-by: Simon Horman <simon.horman@corigine.com>

    \
     
     \ /
      Last update: 2023-03-27 00:47    [W:4.403 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site