lkml.org 
[lkml]   [2023]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/11] scsi: scsi_debug: Don't hold driver host struct pointer in host->hostdata[]
From
On 07/03/2023 14:58, Bart Van Assche wrote:
> On 3/7/23 02:55, John Garry wrote:
>> +#define to_sdebug_host_from_shost(shost)    \
>> +    to_sdebug_host(shost->dma_dev)
>
> Please make the name of this macro shorter and following naming
> conventions used elsewhere in the SCSI core. How about the following
> name: shost_to_sdebug_host()?

ok, fine, I can change that. Maybe then I'll also change
to_sdebug_host() -> dev_to_sdebug_host() to avoid ambiguity.

Thanks,
John

\
 
 \ /
  Last update: 2023-03-27 00:47    [W:0.055 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site