Messages in this thread | | | Date | Tue, 7 Mar 2023 14:17:56 +0100 | Subject | Re: [PATCH] igb: revert rtnl_lock() that causes deadlock | From | "Linux regression tracking (Thorsten Leemhuis)" <> |
| |
On 07.03.23 14:05, Lin Ma wrote: > The commit 6faee3d4ee8b ("igb: Add lock to avoid data race") adds > rtnl_lock to eliminate a false data race shown below > > (FREE from device detaching) | (USE from netdev core) > igb_remove | igb_ndo_get_vf_config > igb_disable_sriov | vf >= adapter->vfs_allocated_count? > kfree(adapter->vf_data) | > adapter->vfs_allocated_count = 0 | > | memcpy(... adapter->vf_data[vf] > > [...] > CC: stable@vger.kernel.org > Fixes: 6faee3d4ee8b ("igb: Add lock to avoid data race") > Reported-by: Corinna <vinschen@redhat.com> > Link: https://lore.kernel.org/regressions/3ef31c0b-ce40-20d0-7740-5dc0cca278ca@molgen.mpg.de/
FWIW, that afaics should be:
Link: https://lore.kernel.org/intel-wired-lan/ZAcJvkEPqWeJHO2r@calimero.vinschen.de/
(that's the parent of the mail above)
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
Ciao, Thorsten
| |