Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 7 Mar 2023 14:08:34 +0100 | Subject | Re: [PATCH 02/20] pinctrl: amd: remove MODULE_LICENSE in non-modules |
| |
On Tue, Feb 28, 2023 at 2:02 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Basavaraj Natikar <Basavaraj.Natikar@amd.com> > Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-gpio@vger.kernel.org
Can I just merge the 3 pinctrl patches to the pinctrl tree or are there any dependencies?
Yours, Linus Walleij
| |