Messages in this thread | | | Date | Tue, 7 Mar 2023 12:36:11 +0100 | From | Thorsten Leemhuis <> | Subject | Re: [PATCH v4 2/3] checkpatch: warn when Reported-by: is not followed by Link: |
| |
On 06.03.23 09:53, Dmitry Vyukov wrote: > On Fri, 3 Mar 2023 at 03:10, Andrew Morton <akpm@linux-foundation.org> wrote: >>>> We can parse out our hash from any tag, but the problem is that the >>>> current email api we use, does not allow to specify Message-ID before >>>> sending, so we don't know it when generating the text. >>>> We don't even know it after sending, the API is super simple: >>>> https://pkg.go.dev/google.golang.org/appengine/mail >>>> So we don't know what the lore link will be... >>> >>> That's... unfortunate, as from my understanding of things that would be >>> the most important "Link:" to have in any patches that fix issues report >>> by syzbot. But well, that's how it is for now. In that case I'd vote for >>> this: >>> >>> Reported-by: syzbot@syzkaller.appspotmail.com >>> Link: https://syzkaller.appspot.com/b/cafecafecaca0cafecafe >> >> As you previously mentioned, patch preparers should also include >> the lore link so any followup discussion is easily located. > > If the link we need to include is to lore, then we don't need to > change the current syzbot Reported-by, right? Instead of asking 3 > tags, we can ask only for: > > Reported-by: syzbot+df61b36319e045c00a08@syzkaller.appspotmail.com > Link: https://lore.kernel.org/r/cafecafecaca0cafecafe@google.com/
Yeah, that's not perfect (see below), but at least better. As mentioned earlier: if the Reported-by: includes the sysbot-id (e.g. the df61b36319e045c00a08) is up to you.
> But as I mentioned we can't provide the lore link at the moment, we > can only add a text to ask to include it.
Yeah, that would be good. Normally it's the oblation of the developer anyway to add Link: tags to any report (which most of the time means: in lore) when fixing things. Obviously the chance that they actually do it is a lot bigger when syzbot would suggest it.
> This also means that checkpatch does not need special casing for syzbot.
Yup
Ciao, Thorsten
| |