Messages in this thread | | | Date | Tue, 7 Mar 2023 10:43:08 +0100 | From | Luca Ceresoli <> | Subject | Re: [PATCH v2 02/23] interconnect: fix icc_provider_del() error handling |
| |
On Mon, 6 Mar 2023 08:56:30 +0100 Johan Hovold <johan+linaro@kernel.org> wrote:
> The interconnect framework currently expects that providers are only > removed when there are no users and after all nodes have been removed. > > There is currently nothing that guarantees this to be the case and the > framework does not do any reference counting, but refusing to remove the > provider is never correct as that would leave a dangling pointer to a > resource that is about to be released in the global provider list (e.g. > accessible through debugfs). > > Replace the current sanity checks with WARN_ON() so that the provider is > always removed. > > Fixes: 11f1ceca7031 ("interconnect: Add generic on-chip interconnect API") > Cc: stable@vger.kernel.org # 5.1: 680f8666baf6: interconnect: Make icc_provider_del() return void > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
[Tested on i.MX8MP using an MSC SM2-MB-EP1 Board] Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
-- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |