Messages in this thread | | | Date | Tue, 7 Mar 2023 10:19:50 +0100 | From | Neil Armstrong <> | Subject | Re: [PATCH 2/2] gpu/drm/panel: Add Lenovo NT36523W BOE panel |
| |
Hi,
On 17/02/2023 12:29, Konrad Dybcio wrote: > Introduce support for the BOE panel with a NT36523W touch/driver IC > found on some Lenovo Tab P11 devices. It's a 2000x1200, 24bit RGB > MIPI DSI panel with integrated DCS-controlled backlight (that expects > big-endian communication). > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-lenovo-nt36523w-boe.c | 751 ++++++++++++++++++++++ > 3 files changed, 764 insertions(+) >
<snip>
> diff --git a/drivers/gpu/drm/panel/panel-lenovo-nt36523w-boe.c b/drivers/gpu/drm/panel/panel-lenovo-nt36523w-boe.c > new file mode 100644 > index 000000000000..83478e471493 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-lenovo-nt36523w-boe.c > @@ -0,0 +1,751 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2023 Linaro Limited > + * > + * Generated with linux-mdss-dsi-panel-driver-generator with > + * some manual adjustments. > + */
<snip>
> +static int nt36523w_boe_bl_update_status(struct backlight_device *bl) > +{ > + struct mipi_dsi_device *dsi = bl_get_data(bl); > + u16 brightness = backlight_get_brightness(bl); > + int ret; > + > + brightness = cpu_to_be16(brightness); > + > + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > + > + ret = mipi_dsi_dcs_set_display_brightness(dsi, brightness); > + if (ret < 0) > + return ret;
It's not wrong as is, but could you switch to mipi_dsi_dcs_set_display_brightness_large() ?
> + > + dsi->mode_flags |= MIPI_DSI_MODE_LPM; > + > + return 0; > +} > + > +static int nt36523w_boe_bl_get_brightness(struct backlight_device *bl) > +{ > + struct mipi_dsi_device *dsi = bl_get_data(bl); > + u16 brightness; > + int ret; > + > + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > + > + ret = mipi_dsi_dcs_get_display_brightness(dsi, &brightness);
And here to mipi_dsi_dcs_get_display_brightness_large() ? > + if (ret < 0) > + return ret; > + > + dsi->mode_flags |= MIPI_DSI_MODE_LPM; > + > + brightness = be16_to_cpu(brightness); > + > + return brightness; > +} > + Please send a v2 with those changes and keep my reviewed-by
Thanks! Neil
| |