Messages in this thread | | | From | Lukas Bulwahn <> | Date | Tue, 7 Mar 2023 09:38:16 +0100 | Subject | Re: [PATCH] arch: sh: remove references to config USB_OHCI_SH |
| |
On Tue, Mar 7, 2023 at 9:19 AM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > > Hi Geert! > > On Tue, 2023-03-07 at 09:16 +0100, Geert Uytterhoeven wrote: > > Hi Lukas, > > > > On Tue, Mar 7, 2023 at 9:02 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > > Commit 4f6dfc2136fb ("usb: remove the dead USB_OHCI_SH option") left some > > > references to the config USB_OHCI_SH in ./arch/sh/ around, expecting those > > > to be removed with the whole SH architecture deletion. > > > > > > As that did not happen, do minor clean-up instead and remove the references > > > to the removed config USB_OHCI_SH instead. > > > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > > > Thanks for your patch! > > > > > --- a/arch/sh/Kconfig > > > +++ b/arch/sh/Kconfig > > > @@ -326,7 +326,6 @@ config CPU_SUBTYPE_SH7720 > > > select CPU_SH3 > > > select CPU_HAS_DSP > > > select SYS_SUPPORTS_SH_CMT > > > - select USB_OHCI_SH if USB_OHCI_HCD > > > > Shouldn't this select USB_OHCI_HCD_PLATFORM instead, as the (now > > removed) Kconfig help text for USB_OHCI_SH used to say? > > > > + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD > > > > I completely forgot I already made that comment before, cfr. > > https://lore.kernel.org/all/CAMuHMdVM3BpvVD3c4gp1OidnwF5zFd4MJecij7zWBnahzNaSNw@mail.gmail.com > > > > The same is true for the three selects below. > > As USB is now broken, the proper solution will need > > Fixes: 4f6dfc2136fb2e8d ("usb: remove the dead USB_OHCI_SH option") >
Well, I assumed that I am just cleaning up some minor stuff, not fixing broken code...
With your link and explanation, Geert, I know what needs to be done. Thanks.
> Thanks a lot for catching this! > > @Lukas: Can you send a new patch with the suggested changes? >
I will send a new patch in a second.
Lukas
> Adrian > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian Developer > `. `' Physicist > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
| |