Messages in this thread | | | Date | Tue, 7 Mar 2023 15:32:14 -0700 | Subject | Re: [PATCH] bus: mhi: host: pci_generic: Drop redundant pci_enable_pcie_error_reporting() | From | Jeffrey Hugo <> |
| |
On 3/7/2023 1:16 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core does this for all devices during enumeration, so the > driver doesn't need to do it itself. > > Remove the redundant pci_enable_pcie_error_reporting() call from the > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > from the driver .remove() path. > > Note that this only controls ERR_* Messages from the device. An ERR_* > Message may cause the Root Port to generate an interrupt, depending on the > AER Root Error Command register managed by the AER service driver. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Looks sane to me.
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
| |