Messages in this thread | | | Date | Tue, 7 Mar 2023 20:59:03 +0100 | Subject | Re: [PATCH v2] checkpatch: Ignore ETHTOOL_LINK_MODE_ enum values | From | Gerhard Engleder <> |
| |
On 05.01.23 23:24, Joe Perches wrote: > On Wed, 2023-01-04 at 21:15 +0100, Gerhard Engleder wrote: >> Since commit 4104a20646 enum values like >> ETHTOOL_LINK_MODE_Asym_Pause_BIT are ignored. But there are other enums >> like ETHTOOL_LINK_MODE_1000baseT_Full_BIT, which are not ignored >> because of the not matching '1000baseT' substring. >> >> Add regex to match all ETHTOOL_LINK_MODE enums. > [] >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] >> @@ -5783,6 +5783,8 @@ sub process { >> $var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ && >> #Ignore Page<foo> variants >> $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && >> +#Ignore ETHTOOL_LINK_MODE_<foo> variants >> + $var !~ /^ETHTOOL_LINK_MODE_/ && >> #Ignore SI style variants like nS, mV and dB >> #(ie: max_uV, regulator_min_uA_show, RANGE_mA_VALUE) >> $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ && > > These ETHTOOL enums also exist but are caught by the SI style variants test > > ETHTOOL_A_CABLE_PULSE_mV > ETHTOOL_A_CABLE_AMPLITUDE_mV > > So I guess it's OK. Thanks.
Did I miss to do something to get this merged? Shall I post it again?
Gerhard
| |