Messages in this thread | | | From | Frank Wunderlich <> | Subject | Aw: [PATCH net-next v12 08/18] net: ethernet: mtk_eth_soc: fix 1000Base-X and 2500Base-X modes | Date | Tue, 7 Mar 2023 19:52:54 +0100 |
| |
> Gesendet: Dienstag, 07. März 2023 um 16:53 Uhr > Von: "Daniel Golle" <daniel@makrotopia.org> > > After conversion to phylink_pcs the 1000Base-X and 2500Base-X modes > would work only after `ethtool -s eth1 autoneg off`. > As ethtool autoneg and the ETHTOOL_LINK_MODE_Autoneg_BIT is supposed > to control auto-negotiation on the external interface it doesn't make > much sense to use it to control on-board SGMII auto-negotiation between > MAC and PHY. > Set correct values to really only enable SGMII auto-negotiation when > actually operating in SGMII mode. For 1000Base-X and 2500Base-X mode, > enable remote-fault detection only if in-band-status is enabled. > This fixes using 1000Base-X and 2500Base-X SFPs on the BananaPi R3 > board and also makes it possible to use interface-mode-switching PHYs > operating in either SGMII mode for 10M/100M/1000M or in 2500Base-X for > 2500M mode on other boards.
Hi,
have tested Parts 1-12 this on bananapi-r3 (mt7986) with 1G Fiber SFP (no 2g5 available yet) on gmac1 and lan4 (mt7531 p5)
Tested-by: Frank Wunderlich <frank-w@public-files.de>
Thx Daniel for working on SFP support :)
regards Frank
| |