Messages in this thread | | | Date | Tue, 7 Mar 2023 11:55:11 -0600 | Subject | Re: [PATCH 4/6] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path | From | Andrew Davis <> |
| |
On 3/7/23 11:44 AM, Andy Shevchenko wrote: > On Tue, Mar 07, 2023 at 10:54:30AM -0600, Andrew Davis wrote: >> Use devm version of gpiochip add function to handle removal for us. >> >> While here update copyright and module author. > > ... > >> - mutex_destroy(&gpio->lock); > > You need to wrap this into devm. >
I was thinking that but it seems there is no such thing. Most drivers just ignore unwinding mutex_init() since it doesn't allocate anything.
mutex_destroy() is a NOP unless you are doing DEBUG builds were it sets a magic value to check for use-after-free issues.
Andrew
| |