Messages in this thread Patch in this message | | | Date | Mon, 6 Mar 2023 15:28:33 +0000 | From | Wei Liu <> | Subject | Re: [PATCH v3] Drivers: vmbus: Check for channel allocation before looking up relids |
| |
On Mon, Feb 20, 2023 at 02:23:50PM +0000, Wei Liu wrote: > On Fri, Feb 17, 2023 at 11:17:04PM +0000, Dexuan Cui wrote: > > > From: Mohammed Gamal <mgamal@redhat.com> > > > Sent: Friday, February 17, 2023 12:44 PM > > > ... > > > --- a/drivers/hv/connection.c > > > +++ b/drivers/hv/connection.c > > > @@ -409,6 +409,10 @@ void vmbus_disconnect(void) > > > */ > > > struct vmbus_channel *relid2channel(u32 relid) > > > { > > > + if (vmbus_connection.channels == NULL) { > > > + pr_warn_once("relid2channel: relid=%d: No channels mapped!\n", > > > relid); > > > > Looks good to me except that the line exceeds 80 characters. > > Please run "scripts/checkpatch.pl" to detect that. > > For this patch, I guess Wei may be willing to help fix it. > > > > > + return NULL; > > > + } > > > if (WARN_ON(relid >= MAX_CHANNEL_RELIDS)) > > > return NULL; > > > return READ_ONCE(vmbus_connection.channels[relid]); > > > -- > > > > Reviewed-by: Dexuan Cui <decui@microsoft.com> > > I will pick this up via hyperv-fixes.
Now applied to hyperv-fixes.
Thanks, Wei.
| |