Messages in this thread | | | From | Lorenz Bauer <> | Date | Mon, 6 Mar 2023 09:26:25 +0000 | Subject | Re: [PATCH] btf: fix resolving BTF_KIND_VAR after ARRAY, STRUCT, UNION, PTR |
| |
On Fri, Mar 3, 2023 at 12:16 AM Martin KaFai Lau <martin.lau@linux.dev> wrote: > > lgtm. Could it be moved out of the for loop?
Yeah, that is possible I think, since we can only trigger the problem if
return env_stack_push()
Is executed. I'll send a v2.
> Please add the test case described in the commit message to the prog_tests/btf.c.
Good point, I'll send this as a separate commit. Backporting patches doesn't work well in my experience.
Thanks for your review! Lorenz
| |