Messages in this thread | | | From | Alexander Aring <> | Date | Mon, 6 Mar 2023 19:06:31 -0500 | Subject | Re: [PATCH next] ca8210: Fix unsigned mac_len comparison with zero in ca8210_skb_tx() |
| |
Hi,
On Mon, Mar 6, 2023 at 2:20 PM Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote: > > mac_len is of type unsigned, which can never be less than zero. > > mac_len = ieee802154_hdr_peek_addrs(skb, &header); > if (mac_len < 0) > return mac_len; > > Change this to type int as ieee802154_hdr_peek_addrs() can return negative > integers, this is found by static analysis with smatch. > > Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Acked-by: Alexander Aring <aahringo@redhat.com>
sorry, I didn't see that... Thanks for sending this patch.
- Alex
| |