lkml.org 
[lkml]   [2023]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 5/5] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua
From
On 06/03/2023 16:14, Stephan Gerhold wrote:
> There are*a lot* of unused pinctrl entries here. If you don't reference
> them anywhere (by referencing them via label) they just waste space in
> the device tree. The GPIOs will still remain unconfigured.
>
> Please save them locally for later usage and only keep the used entries.
> This will ease review of upcoming patches since these are better
> understandable together with the actual device node making use of them.

TBH, I really would have rather received this comment @ version 1,
before doing all the work to sanitise the incoming downstream DTS.

But sure, no problem, I'll drop.

---
bod

\
 
 \ /
  Last update: 2023-03-27 00:46    [W:0.043 / U:1.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site