Messages in this thread | | | Date | Mon, 6 Mar 2023 23:41:50 +0300 | From | Fedor Pchelkin <> | Subject | Re: [PATCH] nfc: change order inside nfc_se_io error path |
| |
On Mon, Mar 06, 2023 at 11:35:09PM +0300, Fedor Pchelkin wrote: > On Mon, Mar 06, 2023 at 04:28:12PM +0100, Krzysztof Kozlowski wrote: > > On 04/03/2023 17:48, Fedor Pchelkin wrote: > > > cb_context should be freed on error paths in nfc_se_io as stated by commit > > > 25ff6f8a5a3b ("nfc: fix memory leak of se_io context in nfc_genl_se_io"). > > > > > > Make the error path in nfc_se_io unwind everything in reverse order, i.e. > > > free the cb_context after unlocking the device. > > > > > > No functional changes intended - only adjusting to good coding practice. > > > > I would argue that it is functional. Running code in or outside of > > critical section/locks is quite functional change. > > > > Hmm, actually, yes. I'll resend v2 with changed commit info as 'no > functional changes' statement can probably be misunderstood later. > > Should this patch be backported by the way? It doesn't seem to fix any > real issue but, as you mentioned, it contains some functional changes > which may be of some importance in future.
Sorry for the noise. Didn't see the patch was already applied. So it's okay as it is.
| |