Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 6 Mar 2023 20:27:19 +0100 | Subject | Re: [PATCH 2/3] arm64: dts: renesas: rzg2l-smarc: Add OV5645 node |
| |
Hi Prabhakar,
On Thu, Feb 16, 2023 at 6:57 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > OV5645 sensor can be connected to the CN1 connector on the > carrier board. This patch adds the ov5645 node under i2c0 node. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dts > +++ b/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dts > @@ -6,6 +6,10 @@ > */ > > /dts-v1/; > + > +/* comment the #define statement if OV5645 is not connected to CN1 */ > +#define CAM_INTERFACE_OV5645 1
I believe the camera is optional ("can be connector" above). So shouldn't this be commented out by default?
The rest LGTM, so with the above sorted out: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |