Messages in this thread | | | Date | Sat, 4 Mar 2023 16:22:51 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 2/4] cxl/pci: Find and register CXL PMU devices |
| |
Hi Jonathan,
I love your patch! Yet something to improve:
[auto build test ERROR on cxl/next] [also build test ERROR on cxl/pending linus/master next-20230303] [cannot apply to v6.2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cameron/cxl-Add-function-to-count-regblocks-of-a-given-type/20230304-015342 base: https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git next patch link: https://lore.kernel.org/r/20230303175022.10806-3-Jonathan.Cameron%40huawei.com patch subject: [PATCH 2/4] cxl/pci: Find and register CXL PMU devices config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20230304/202303041611.MbSDCPTb-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0790ed82bb7adf04c834e8c03008b92c1b23945e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jonathan-Cameron/cxl-Add-function-to-count-regblocks-of-a-given-type/20230304-015342 git checkout 0790ed82bb7adf04c834e8c03008b92c1b23945e # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303041611.MbSDCPTb-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/cxl/core/port.c:60:20: error: use of undeclared identifier 'cxl_cpmu_type'; did you mean 'cxl_bus_type'? if (dev->type == &cxl_cpmu_type) ^~~~~~~~~~~~~ cxl_bus_type drivers/cxl/cxl.h:732:24: note: 'cxl_bus_type' declared here extern struct bus_type cxl_bus_type; ^ 1 error generated. -- >> drivers/cxl/core/regs.c:9:10: fatal error: 'cpmu.h' file not found #include <cpmu.h> ^~~~~~~~ 1 error generated. -- >> drivers/cxl/core/cpmu.c:8:10: fatal error: 'cpmu.h' file not found #include <cpmu.h> ^~~~~~~~ 1 error generated.
vim +60 drivers/cxl/core/port.c
40 41 static int cxl_device_id(struct device *dev) 42 { 43 if (dev->type == &cxl_nvdimm_bridge_type) 44 return CXL_DEVICE_NVDIMM_BRIDGE; 45 if (dev->type == &cxl_nvdimm_type) 46 return CXL_DEVICE_NVDIMM; 47 if (dev->type == CXL_PMEM_REGION_TYPE()) 48 return CXL_DEVICE_PMEM_REGION; 49 if (dev->type == CXL_DAX_REGION_TYPE()) 50 return CXL_DEVICE_DAX_REGION; 51 if (is_cxl_port(dev)) { 52 if (is_cxl_root(to_cxl_port(dev))) 53 return CXL_DEVICE_ROOT; 54 return CXL_DEVICE_PORT; 55 } 56 if (is_cxl_memdev(dev)) 57 return CXL_DEVICE_MEMORY_EXPANDER; 58 if (dev->type == CXL_REGION_TYPE()) 59 return CXL_DEVICE_REGION; > 60 if (dev->type == &cxl_cpmu_type) 61 return CXL_DEVICE_CPMU; 62 return 0; 63 } 64
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
| |