lkml.org 
[lkml]   [2023]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.1 35/60] USB: gadget: bcm63xx_udc: fix memory leak with using debugfs_lookup()
    Date
    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    [ Upstream commit a91c99b1fe5c6f7e52fb932ad9e57ec7cfe913ec ]

    When calling debugfs_lookup() the result must have dput() called on it,
    otherwise the memory will leak over time. To make things simpler, just
    call debugfs_lookup_and_remove() instead which handles all of the logic
    at once.

    Cc: Kevin Cernekee <cernekee@gmail.com>
    Link: https://lore.kernel.org/r/20230202153235.2412790-9-gregkh@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/udc/bcm63xx_udc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_udc.c
    index d04d72f5816e6..8d58928913007 100644
    --- a/drivers/usb/gadget/udc/bcm63xx_udc.c
    +++ b/drivers/usb/gadget/udc/bcm63xx_udc.c
    @@ -2258,7 +2258,7 @@ static void bcm63xx_udc_init_debugfs(struct bcm63xx_udc *udc)
    */
    static void bcm63xx_udc_cleanup_debugfs(struct bcm63xx_udc *udc)
    {
    - debugfs_remove(debugfs_lookup(udc->gadget.name, usb_debug_root));
    + debugfs_lookup_and_remove(udc->gadget.name, usb_debug_root);
    }

    /***********************************************************************
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-03-27 00:43    [W:5.562 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site