Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 3 Mar 2023 08:52:30 +0100 | Subject | Re: [PATCH 05/17] drivers: bus: simple-pm-bus: remove MODULE_LICENSE in non-modules |
| |
Hi Nick,
On Thu, Mar 2, 2023 at 11:25 PM Nick Alcock <nick.alcock@oracle.com> wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Thanks for your patch!
> --- a/drivers/bus/simple-pm-bus.c > +++ b/drivers/bus/simple-pm-bus.c > @@ -92,4 +92,3 @@ module_platform_driver(simple_pm_bus_driver); > > MODULE_DESCRIPTION("Simple Power-Managed Bus Driver"); > MODULE_AUTHOR("Geert Uytterhoeven <geert+renesas@glider.be>"); > -MODULE_LICENSE("GPL v2");
Please do not remove this line as long as the file has no SPDX-License tag.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |