Messages in this thread | ![/](/images/icornerl.gif) | | From | Heiko Stübner <> | Subject | Re: [PATCH v5 06/18] thermal: Remove debug or error messages in get_temp() ops | Date | Fri, 03 Mar 2023 16:47:55 +0100 |
| |
Am Mittwoch, 1. März 2023, 21:14:34 CET schrieb Daniel Lezcano: > Some get_temp() ops implementation are showing an error or a debug > message if the reading of the sensor fails. > > The debug message is already displayed from the call site of this > ops. So we can remove it. > > On the other side, the error should not be displayed because in > production that can raise tons of messages. > > Finally, some drivers are showing a debug message with the > temperature, this is also accessible through the trace from the core > code in the temperature_update() function. > > Another benefit is the dev_* messages are accessing the thermal zone > device field from the structure, so we encapsulate even more the code > by preventing these accesses. > > Remove those messages. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> #Armada > Acked-by: Florian Fainelli <f.fainelli@gmail.com> #brcmstb_thermal.c
Acked-by: Heiko Stuebner <heiko@sntech.de> #rockchip
| ![\](/images/icornerr.gif) |