Messages in this thread | | | Date | Fri, 3 Mar 2023 15:06:41 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] HID: intel-ish-hid: ipc: Fix potential use-after-free in work function |
| |
On Mon, 27 Feb 2023, Reka Norman wrote:
> When a reset notify IPC message is received, the ISR schedules a work > function and passes the ISHTP device to it via a global pointer > ishtp_dev. If ish_probe() fails, the devm-managed device resources > including ishtp_dev are freed, but the work is not cancelled, causing a > use-after-free when the work function tries to access ishtp_dev. Use > devm_work_autocancel() instead, so that the work is automatically > cancelled if probe fails. > > Signed-off-by: Reka Norman <rekanorman@chromium.org>
Applied, thank you.
-- Jiri Kosina SUSE Labs
| |