Messages in this thread Patch in this message | | | From | <> | Subject | Re: [PATCH 19/27] irqchip/mchp-eic: remove MODULE_LICENSE in non-modules | Date | Fri, 3 Mar 2023 11:23:31 +0000 |
| |
On 24.02.2023 17:08, Nick Alcock wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Marc Zyngier <maz@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> --- > drivers/irqchip/irq-mchp-eic.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/irqchip/irq-mchp-eic.c b/drivers/irqchip/irq-mchp-eic.c > index c726a19837d2..5dcd94c000a2 100644 > --- a/drivers/irqchip/irq-mchp-eic.c > +++ b/drivers/irqchip/irq-mchp-eic.c > @@ -276,5 +276,4 @@ IRQCHIP_MATCH("microchip,sama7g5-eic", mchp_eic_init) > IRQCHIP_PLATFORM_DRIVER_END(mchp_eic) > > MODULE_DESCRIPTION("Microchip External Interrupt Controller"); > -MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR("Claudiu Beznea <claudiu.beznea@microchip.com>"); > -- > 2.39.1.268.g9de2f9a303 >
| |