Messages in this thread | | | Date | Wed, 29 Mar 2023 12:07:56 -0400 | Subject | Re: [PATCH 2/2] drm/amd/display: Add previous prototype to 'optc3_wait_drr_doublebuffer_pending_clear' | From | Hamza Mahfooz <> |
| |
On 3/28/23 18:09, Caio Novais wrote: > Compiling AMD GPU drivers displays a warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes] > > Get rid of it by adding a function prototype > > 'optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)' on drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h > > Signed-off-by: Caio Novais <caionovais@usp.br> > --- > drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h > index fb06dc9a4893..2e3ba6e2f336 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h > +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h > @@ -331,6 +331,8 @@ void optc3_lock_doublebuffer_enable(struct timing_generator *optc); > > void optc3_lock_doublebuffer_disable(struct timing_generator *optc); > > +void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc);
I would prefer if you marked the function as static instead, since it is only used in dcn30_optc.c.
> + > void optc3_set_drr_trigger_window(struct timing_generator *optc, > uint32_t window_start, uint32_t window_end); >
-- Hamza
| |