lkml.org 
[lkml]   [2023]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] gpiolib: Split property name from the warning message
On Wed, Mar 29, 2023 at 01:37:16PM +0200, Bartosz Golaszewski wrote:
> On Tue, Mar 21, 2023 at 2:52 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

...

> > - dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n",
> > - count, chip->offset);
> > + dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n",
> > + "gpio-line-names", count, chip->offset);
> > return 0;
> > }
>
> I'd say being able to grep the code easily for messages is more
> important than saving a couple bytes here?

We still grep by the rest of the message. But anyway, up to you,
I've no hard feelings to this patch.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-03-29 15:56    [W:0.034 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site