Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 29 Mar 2023 16:55:30 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] gpiolib: Split property name from the warning message |
| |
On Wed, Mar 29, 2023 at 01:37:16PM +0200, Bartosz Golaszewski wrote: > On Tue, Mar 21, 2023 at 2:52 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote:
...
> > - dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n", > > - count, chip->offset); > > + dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n", > > + "gpio-line-names", count, chip->offset); > > return 0; > > } > > I'd say being able to grep the code easily for messages is more > important than saving a couple bytes here?
We still grep by the rest of the message. But anyway, up to you, I've no hard feelings to this patch.
-- With Best Regards, Andy Shevchenko
| ![\](/images/icornerr.gif) |