Messages in this thread | | | Date | Wed, 29 Mar 2023 15:41:26 +0200 | From | Simon Horman <> | Subject | Re: [PATCH] net: ksz884x: remove unused change variable |
| |
On Wed, Mar 29, 2023 at 03:23:38PM +0200, Simon Horman wrote: > On Wed, Mar 29, 2023 at 08:59:29AM -0400, Tom Rix wrote: > > clang with W=1 reports > > drivers/net/ethernet/micrel/ksz884x.c:3216:6: error: variable > > 'change' set but not used [-Werror,-Wunused-but-set-variable] > > int change = 0; > > ^ > > This variable is not used so remove it. > > > > Signed-off-by: Tom Rix <trix@redhat.com> > > Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hi Tom,
I notice a very large number of unused functions in ksz884x.c. And I think this means some corresponding #defines can also be removed.
I'm wondering if you happen to be looking at this. If not, I'll see about preparing a patch.
| |