Messages in this thread | | | Date | Wed, 29 Mar 2023 15:36:14 +0200 | Subject | Re: [PATCH RESEND 3/6] arm64: dts: mediatek: add power domain support for mt8365 SoC | From | AngeloGioacchino Del Regno <> |
| |
Il 29/03/23 11:52, Alexandre Mergnat ha scritto: > The following power domain are added to the SoC dts: > - MM (MultiMedia) > - CONN (Connectivity) > - MFG (MFlexGraphics) > - Audio > - Cam (Camera) > - DSP (Digital Signal Processor) > - Vdec (Video decoder) > - Venc (Video encoder) > - APU (AI Processor Unit) > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt8365.dtsi | 129 +++++++++++++++++++++++++++++++ > 1 file changed, 129 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > index b5f5c77f7f84..67b375fe2020 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > @@ -9,6 +9,7 @@
..snip..
> + > watchdog: watchdog@10007000 { > compatible = "mediatek,mt8365-wdt", > "mediatek,mt6589-wdt"; > @@ -592,6 +702,25 @@ u2port1: usb-phy@1000 { > #phy-cells = <1>; > }; > }; > + > + mmsys: syscon@14000000 {
These are not power domains... either introduce them in a different commit or at least please mention the addition in the commit title/description.
Personally, I would split that addition in a different commit, explaining what mmsys, camsys and apu clocks are ;-)
Regards, Angelo
| |