Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 29 Mar 2023 13:32:40 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH 2/2] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe_recover() |
| |
On Fri, Mar 24, 2023 at 10:55:41AM +0800, Jiapeng Chong wrote: > The error code is missing in this code scenario, add the error code > '-EINVAL' to the return value 'err'. > > drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c:105 mlx5e_tx_reporter_err_cqe_recover() warn: missing error code 'err'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4600 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c > index 44c1926843a1..5e2e2449668d 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c > @@ -101,8 +101,10 @@ static int mlx5e_tx_reporter_err_cqe_recover(void *ctx) > goto out; > } > > - if (state != MLX5_SQC_STATE_ERR) > + if (state != MLX5_SQC_STATE_ERR) { > + err = -EINVAL;
Same comment as for patch #1.
> goto out; > + } > > mlx5e_tx_disable_queue(sq->txq); > > -- > 2.20.1.7.g153144c >
| ![\](/images/icornerr.gif) |